Skip to content

Conversation

@guykhazma
Copy link
Contributor

What changes were proposed in this pull request?

The 3rd link in IBM Cloud Object Storage connector for Apache Spark is broken. The PR removes this link.

Why are the changes needed?

broken link

Does this PR introduce any user-facing change?

yes, the broken link is removed from the doc.

How was this patch tested?

doc generation passes successfully as before

@dilipbiswal
Copy link
Contributor

cc @skambha @huaxingao Can you please help check if this link https://developer.ibm.com/?s=installing-running-stocator-apache-spark-ibm-cloud-object-storage has moved some place else.

@guykhazma
Copy link
Contributor Author

guykhazma commented Jun 25, 2020

@dilipbiswal @skambha @huaxingao the preference for now is to remove this link entirely.

@HyukjinKwon
Copy link
Member

ok to test

@SparkQA
Copy link

SparkQA commented Jun 26, 2020

Test build #124526 has finished for PR 28927 at commit a0756db.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @guykhazma . Merged to master/3.0.
The GitHub (https://github.com/CODAIT/stocator) seems to have an enough resource for that. We can add a new link later if it is found later.

dongjoon-hyun pushed a commit that referenced this pull request Jun 27, 2020
…tion

### What changes were proposed in this pull request?

The 3rd link in `IBM Cloud Object Storage connector for Apache Spark` is broken. The PR removes this link.

### Why are the changes needed?

broken link

### Does this PR introduce _any_ user-facing change?

yes, the broken link is removed from the doc.

### How was this patch tested?

doc generation passes successfully as before

Closes #28927 from guykhazma/spark32099.

Authored-by: Guy Khazma <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
(cherry picked from commit 44aecaa)
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants